support packages that use modules #1556
Conversation
we should allow babel to handle any features the library is using to match the targets set in the app
|
I think this a fine incremental improvement and we can merge it. But in the medium term, I expect this to be wrong because depending on the specifics of your build system, babel may see all kinds of different extensions. But also, this code only exists to power the skipBabel option, which is only needed when users don't control their own babel config, which I expect to stop being a thing. |
|
it's fine, more than happy to make this change in my own webpack/babel config one in able to but right now can't due to this being hardcoded this came up for me while trying to get embroider working for an app with a requiement for ie 11 as a target and not having any success with passing webpack config for targets : ['web','es5'] |
.mjs files can be imported directly by an app
we should allow babel to handle any features the library is using to match the targets set in the app
babel is more than capable of transpiling .mjs files as it's an unambiguous extension that could use features the user is not targeting like private fields or the next hottest ecma script proposal.
this change optionally matches those files as well for processing by babel when stage3 asks about it.